mistercrunch commented on PR #32969: URL: https://github.com/apache/superset/pull/32969#issuecomment-2772981332
I'm open to a SIP here, but don't think this is controversial, especially behind a feature flag. As long as it fits the implementation for dashboards, its in many ways is even more needed for Charts, given that there's an order of magnitude more charts than there are dashboards. Some clarifying questions (whether it's for the SIP or PR...) - we should clarify whether published/draft affects access or RBAC (?) From my understanding it doesn't/shouldn't, meaning draft isn't "private" - other people can access your drafts if they desire, it simply curates the list view (where I believe you see your own drafts + what others have published (?)) - does publishing a dashboard implies that the charts its composed-of are (or should) be published (?) What if you add charts *after* publishing a dashboard? Is it confusing the see a published dashboard made out of "draft" charts (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
