Re: [PR] fix: Bar Chart (legacy) migration to keep labels layout [superset]

Tue, 01 Apr 2025 12:02:59 -0700 


korbit-ai[bot] commented on code in PR #32965:
URL: https://github.com/apache/superset/pull/32965#discussion_r2023525025


##########
superset/migrations/shared/migrate_viz/processors.py:
##########
@@ -236,6 +236,7 @@ def _pre_action(self) -> None:
         self.remove_keys.add("bar_stacked")
 
         self.data["stack"] = "Stack" if self.data.get("bar_stacked") else None
+        self.data["x_ticks_layout"] = 45

Review Comment:
   ### Missing explanation for hardcoded rotation angle <sub>![category 
Documentation](https://img.shields.io/badge/Documentation-7c3aed)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Lack of explanation for the hardcoded value 45 for x_ticks_layout in the 
MigrateBarChart class.
   
   ###### Why this matters
   Without documentation, future maintainers won't understand why this specific 
rotation angle was chosen or if it's a meaningful default.
   
   ###### Suggested change ∙ *Feature Preview*
   # Set default x-axis label rotation to 45 degrees for better readability
   self.data["x_ticks_layout"] = 45
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/cf62e33d-ac4c-4c15-9d12-4154efd2e53f/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/cf62e33d-ac4c-4c15-9d12-4154efd2e53f?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/cf62e33d-ac4c-4c15-9d12-4154efd2e53f?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/cf62e33d-ac4c-4c15-9d12-4154efd2e53f?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/cf62e33d-ac4c-4c15-9d12-4154efd2e53f)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:2caba22c-61f8-4c4e-9bbb-b79c05c525b8 -->
   
   [](2caba22c-61f8-4c4e-9bbb-b79c05c525b8)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to