mistercrunch commented on PR #30760: URL: https://github.com/apache/superset/pull/30760#issuecomment-2764211090
@viyh I just updated the PR: - rebased on latest master - fixed the potential SQL injection issue using the sqla sql toolkit - @betodealmeida I tested with and without the "allow catalog" checkbox Should be go for another round of review and hopefully merging. One thing I noticed - for another PR, is that we don't seem to get the indexes here anymore. The driver has changed and they made get_indexes a no-op now. Something to look at. This current PR is much more critical given the current state of doing a "full scan" on preview -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
