Sameerali0 opened a new pull request, #32890:
URL: https://github.com/apache/superset/pull/32890

   ### SUMMARY
   This PR removes the non-standard `IconButton` component and replaces it with 
the standard `Card` component from Ant Design 5, as part of SIP-139 
https://github.com/apache/superset/issues/29268. The component is currently 
only used in the Database modal.
    
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ### CHANGES
   * Removed `src/components/IconButton` component.
   * Updated all instances to use Ant Design 5's `Card` component instead.
   * Ensured proper styling with minimal custom overrides.
   * Maintained RTL support and existing behavior.
   * Added Storybook coverage for `Card` usage.
   * Added new tests
   
   ### BEFORE/AFTER SCREENSHOTS
   
   #### Before
   
![before](https://github.com/user-attachments/assets/6ed82c9a-d48a-42f3-8991-ab4c0e2011b3)
   
   
   #### After
   
[Screencast_20250328_020258.webm](https://github.com/user-attachments/assets/764f4cda-6311-400d-9b77-ab0c1d2d4e9d)
   
   
[Screencast_20250328_015435.webm](https://github.com/user-attachments/assets/fe159694-9cd1-42f8-a0b3-d39b267de775)
   
   
   ### CHECKLIST
   * [x]  Used Ant Design 5 `Card` component.
   * [x]  Removed unnecessary custom styles.
   * [x]  Added Storybook documentation.
   * [x]  Verified RTL compatibility.
   * [x] Added tests
   * [x] Has associated issue:
   * [x] Changes UI
   Fixes #32823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to