bmaquet opened a new pull request, #32888: URL: https://github.com/apache/superset/pull/32888
### SUMMARY I recently added a new Jinja macro `current_user_roles()` in https://github.com/apache/superset/pull/32770 In this PR I added a new function `get_user_roles()` in `core.py` to get the roles of the logged-in user. However I noticed today there's already a `get_user_roles()` method defined in `superset/security/manager.py` [[source](https://github.com/apache/superset/blob/master/superset/security/manager.py#L2437)]. I'm proposing a small refactor to rely on the existing method instead of the new method I introduced in https://github.com/apache/superset/pull/32770. ### TESTING INSTRUCTIONS I've updated the unit tests accordingly, so they should pass ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
