Re: [PR] fix: make packages PEP 625 compliant [superset]

Wed, 26 Mar 2025 11:25:05 -0700 


korbit-ai[bot] commented on code in PR #32866:
URL: https://github.com/apache/superset/pull/32866#discussion_r2014635145


##########
RELEASING/make_tarball.sh:
##########
@@ -32,7 +32,7 @@ else
   SUPERSET_VERSION="${1}"
   SUPERSET_RC="${2}"
   SUPERSET_PGP_FULLNAME="${3}"
-  
SUPERSET_RELEASE_RC_TARBALL="apache-superset-${SUPERSET_VERSION_RC}-source.tar.gz"
+  
SUPERSET_RELEASE_RC_TARBALL="apache_superset-${SUPERSET_VERSION_RC}-source.tar.gz"

Review Comment:
   ### Variable used before definition <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The variable SUPERSET_VERSION_RC is used before it's defined. The script 
uses this variable in the tarball name before it sets its value a few lines 
later.
   
   ###### Why this matters
   This will result in an empty value being used in the tarball name, causing 
incorrect file naming and potential failures in subsequent operations that 
depend on this filename.
   
   ###### Suggested change ∙ *Feature Preview*
   Move the tarball name definition after SUPERSET_VERSION_RC is set:
   ```bash
   SUPERSET_VERSION_RC="${SUPERSET_VERSION}rc${SUPERSET_RC}"
   
SUPERSET_RELEASE_RC_TARBALL="apache_superset-${SUPERSET_VERSION_RC}-source.tar.gz"
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8a5c9d38-632f-468c-996e-7d4750f1e405/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8a5c9d38-632f-468c-996e-7d4750f1e405?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8a5c9d38-632f-468c-996e-7d4750f1e405?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8a5c9d38-632f-468c-996e-7d4750f1e405?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/8a5c9d38-632f-468c-996e-7d4750f1e405)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:dc3f9e9f-71fc-4c16-8ec1-698f4d584c08 -->
   
   [](dc3f9e9f-71fc-4c16-8ec1-698f4d584c08)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to