mistercrunch commented on PR #30134: URL: https://github.com/apache/superset/pull/30134#issuecomment-2752354816
> @mistercrunch Regarding the testing, what do you think of something like https://github.com/apache/superset/commit/7ccb69c31a0f37f9ff1940f00c177410998f431a Looks like this doubles the size of the matrix, not sure if that's reasonable for a single feature... Would have to do something similar for backend tests (pytest) and normal unit tests (jest). For pytest, it's not sharded and could probably do say "mysql + app_root" and "postgres no-app-route", so it wouldn't affect the CI workload. Exploring options here, maybe a nightly or only on `push` events on `master` would contain the workload quite a bit and allow us to catch-on-merge. Personal preference would be "only run the extra workload" on push to `master`, which is a fraction of the work from doing it on every PR push. Curious what other committers/PMC think though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
