Re: [PR] fix(chart) : big number with trendline subheader handling [superset]

Mon, 24 Mar 2025 15:53:41 -0700 


korbit-ai[bot] commented on code in PR #32832:
URL: https://github.com/apache/superset/pull/32832#discussion_r2011030780


##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/controlPanel.tsx:
##########
@@ -57,6 +57,19 @@ const config: ControlPanelConfig = {
             },
           },
         ],
+        [
+          {
+            name: 'subheader',
+            config: {
+              type: 'TextControl',
+              label: t('Subheader'),
+              renderTrigger: true,
+              description: t(
+                'Description text that shows up below your Big Number. Act as 
a prefix if Comparaison period lag is enabled',
+              ),

Review Comment:
   ### Typo in UI Description Text <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   There is a typo in the word 'Comparaison' (should be 'Comparison') in the 
subheader description text.
   
   ###### Why this matters
   This typo in the UI will appear to users configuring the chart and may cause 
confusion or make the application appear unprofessional.
   
   ###### Suggested change ∙ *Feature Preview*
   Fix the typo in the description text:
   ```typescript
   description: t(
     'Description text that shows up below your Big Number. Act as a prefix if 
Comparison period lag is enabled',
   ),
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b4362236-5367-449b-a74f-3a5550f95cd3/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b4362236-5367-449b-a74f-3a5550f95cd3?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b4362236-5367-449b-a74f-3a5550f95cd3?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b4362236-5367-449b-a74f-3a5550f95cd3?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b4362236-5367-449b-a74f-3a5550f95cd3)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:0cdcc5b0-71ba-474a-aa25-211e379d9c10 -->
   
   [](0cdcc5b0-71ba-474a-aa25-211e379d9c10)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to