geido opened a new issue, #32824: URL: https://github.com/apache/superset/issues/32824
Please refer to SIP-139 https://github.com/apache/superset/issues/29268. The `Upload` component should be upgraded to Ant Design version 5. As all other re-usable components of the codebase the Upload component should have its own wrapper in `src/components/Upload`. Similar work has been completed [here](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed). **IMPORTANT:** - The `src/components/Upload` must be upgraded to Ant Design 5 and a wrapper created inside `src/components/Upload`. - The `src/components/Upload` wrapper should contain a RTL test file and Storybook. - All direct imports of Upload should be refactored to use `src/components/Upload` instead. When upgrading the component to Ant Design 5, please ensure to include: - Do not add unnecessary custom styles. We want to go as vanilla Ant Design as possible. - Proper RTL test coverage. - A Storybook file. - Include all relevant component options in the Storybook. When opening a PR: - Name your PR refactor({Component}): Upgrade {component} to Ant Design 5 - Add screenshots of BEFORE/AFTER in your PR. - Update the [project tracker](https://github.com/apache/superset/discussions/29293) when your PR is merged. - Make sure you or a committer has labeled your PR with [frontend:refactor:antd5](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
