chrisvnimbus commented on code in PR #32792:
URL: https://github.com/apache/superset/pull/32792#discussion_r2007738487
##########
superset/views/base.py:
##########
@@ -319,7 +319,7 @@ def cached_common_bootstrap_data( # pylint:
disable=unused-argument
# verify client has google sheets installed
available_specs = get_available_engine_specs()
- frontend_config["HAS_GSHEETS_INSTALLED"] =
bool(available_specs[GSheetsEngineSpec])
+ frontend_config["HAS_GSHEETS_INSTALLED"] = GSheetsEngineSpec in
available_specs and bool(available_specs[GSheetsEngineSpec])
Review Comment:
This is I think incorrect, consider;
dict = {"A": None}
"A" in dict -> True
bool(dict["A"]) -> False
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
