justinpark commented on code in PR #32548: URL: https://github.com/apache/superset/pull/32548#discussion_r1996278063
########## superset-frontend/src/explore/components/DatasourcePanel/DatasourceItems.tsx: ########## @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { useCallback, useEffect, useMemo, useState } from 'react'; +import { VariableSizeList as List } from 'react-window'; +import { cloneDeep } from 'lodash'; +import { FlattenedItem, Folder } from './types'; +import DatasourcePanelItem from './DatasourcePanelItem'; + +const BORDER_WIDTH = 2; +const HEADER_ITEM_HEIGHT = 50; +const METRIC_OR_COLUMN_ITEM_HEIGHT = 32; +const DIVIDER_ITEM_HEIGHT = 16; + +const flattenFolderStructure = ( + folders: Folder[], + depth = 0, + folderMap: Map<string, Folder> = new Map(), +): { flattenedItems: FlattenedItem[]; folderMap: Map<string, Folder> } => { + const flattenedItems: FlattenedItem[] = []; + + folders.forEach((folder, idx) => { + folderMap.set(folder.id, folder); + + flattenedItems.push({ + type: 'header', + folderId: folder.id, + depth, + height: HEADER_ITEM_HEIGHT, + }); + + if (!folder.isCollapsed) { + folder.items.forEach(item => { + flattenedItems.push({ + type: 'item', + folderId: folder.id, + depth, + item, + height: METRIC_OR_COLUMN_ITEM_HEIGHT, + }); + }); + + if (folder.subFolders && folder.subFolders.length > 0) { + const { flattenedItems: subItems } = flattenFolderStructure( + folder.subFolders, + depth + 1, + folderMap, + ); + + flattenedItems.push(...subItems); + } + } + if (depth === 0 && idx !== folders.length - 1) { + flattenedItems.push({ + type: 'divider', + folderId: folder.id, + depth, + height: DIVIDER_ITEM_HEIGHT, + }); + } + }); + + return { flattenedItems, folderMap }; +}; + +interface DatasourceItemsProps { + width: number; + height: number; + folders: Folder[]; +} +export const DatasourceItems = ({ + width, + height, + folders, +}: DatasourceItemsProps) => { + const [folderStructure, setFolderStructure] = useState<Folder[]>(folders); + + useEffect(() => { + setFolderStructure(prev => (prev !== folders ? folders : prev)); + }, [folders]); + + const { flattenedItems, folderMap } = useMemo( + () => flattenFolderStructure(folderStructure), + [folderStructure], + ); + + const handleToggleCollapse = useCallback((folderId: string) => { + setFolderStructure(prevFolders => { + const updatedFolders = cloneDeep(prevFolders); Review Comment: In the case of Airbnb, when there are over 50k items, using cloneDeep can significantly **impact performance negatively**. Instead of modifying flatterenItems, it's much more efficient to store the collapsed folder IDs in a map when clicked, pass that along with itemData, and then determine whether the collapsed ID is included in the DatasourcePanelItem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
