mistercrunch commented on code in PR #32596:
URL: https://github.com/apache/superset/pull/32596#discussion_r1991922749
##########
.github/workflows/pre-commit.yml:
##########
@@ -56,8 +56,7 @@ jobs:
- name: pre-commit
run: |
set +e # Don't exit immediately on failure
- # Skip auto-fixing in CI to ensure changes are committed locally
- export SKIP_FIX=1
+ export SKIP=eslint-frontend,type-checking-frontend
Review Comment:
I think SKIP_FIX was introduced in your previous PR and isn't referenced
anywhere else in the repo after this PR.
`SKIP` is used for pre-commit steps that are already handled in other GHAs,
in this case those 2 are handled in the `superset-frontend` GHA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
