michael-s-molina commented on code in PR #32608:
URL: https://github.com/apache/superset/pull/32608#discussion_r1991343569
##########
superset-frontend/src/views/CRUD/utils.tsx:
##########
@@ -223,10 +224,14 @@ export const getRecentActivityObjs = (
) =>
SupersetClient.get({ endpoint: recent }).then(recentsRes => {
const res: any = {};
+ const distinctRes = lruCache<RecentActivity>(6);
+ recentsRes.json.result.reverse().forEach((record: RecentActivity) => {
+ distinctRes.set(record.item_url, record);
+ });
return getFilteredChartsandDashboards(addDangerToast, filters).then(
({ other }) => {
res.other = other;
- res.viewed = recentsRes.json.result;
+ res.viewed = distinctRes.values().reverse();
Review Comment:
Is it necessary to reverse twice or can this be optimized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
