mistercrunch opened a new pull request, #32570:
URL: https://github.com/apache/superset/pull/32570
This is WiP, incomplete!
I started migrating tabs but realized there are many more than I thought
originally so want to open this DRAFT PR for cooperation / handoff.
My approach, step-by-step was to start by moving components using tabs to
point to vanilla `antd-v5` alias one by one, while keeping
`src/components/Tabs` untouched (as opposed to altering `src/components/Tabs`
to point to `antd-v5` and fix the broken ones one-by-one). Once all were going
to be migrated, I was planning on switching everything to make
`src/components/Tabs` a very simple wrapper to `antd-v5` and pointing all of
the components to it.
Looks like I did 7 so far, and there are 14 left to migrate:
```bash
$ git grep "src/components/Tabs"
src/SqlLab/components/TabbedSqlEditors/index.tsx:import { EditableTabs }
from 'src/components/Tabs';
src/components/Chart/DrillBy/useResultsTableView.tsx:import Tabs from
'src/components/Tabs';
src/dashboard/components/BuilderComponentPane/index.tsx:import Tabs from
'src/components/Tabs';
src/dashboard/components/DashboardBuilder/DashboardContainer.tsx:import Tabs
from 'src/components/Tabs';
src/dashboard/components/gridComponents/Tabs.jsx:import { LineEditableTabs }
from 'src/components/Tabs';
src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:import
Tabs from 'src/components/Tabs';
src/explore/components/controls/ColumnConfigControl/ColumnConfigPopover.tsx:import
Tabs from 'src/components/Tabs';
src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:import
Tabs from 'src/components/Tabs';
src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx:import
Tabs from 'src/components/Tabs';
src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx:import
Tabs from 'src/components/Tabs';
src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx:import
Tabs from 'src/components/Tabs';
src/features/databases/DatabaseModal/index.tsx:import Tabs from
'src/components/Tabs';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
