korbit-ai[bot] commented on code in PR #32607:
URL: https://github.com/apache/superset/pull/32607#discussion_r1990276854
##########
docs/docusaurus.config.ts:
##########
@@ -329,12 +329,15 @@ const config: Config = {
},
} satisfies ThemeConfig,
scripts: [
- '/script/matomo.js',
// {
// src:
'https://www.bugherd.com/sidebarv2.js?apikey=enilpiu7bgexxsnoqfjtxa',
// async: true,
// },
],
+ customFields: {
+ matomoUrl: 'https://analytics.apache.org',
+ matomoSiteId: '22',
Review Comment:
Thanks for your input. While I do agree that it might not be immediately
necessary, it won't harm following good practices. Adding type definitions
makes the code easier to understand, and helps prevent potential bugs in the
future. Furthermore, it ensures that if someone ever needs to make changes,
they would be less likely to accidentally break something. Would you consider
applying these adjustments in your PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
