dosubot[bot] commented on issue #32591:
URL: https://github.com/apache/superset/issues/32591#issuecomment-2713873113

   <!-- Answer -->
   A similar issue was previously reported in [issue 
#31318](https://github.com/apache/superset/issues/31318), which was closed 
after a fix was implemented in [pull request 
#31752](https://github.com/apache/superset/pull/31752). However, it seems that 
the fix did not resolve the problem for cases with empty cells in the heatmap 
<sup>[[1]](https://github.com/apache/superset/issues/31318)</sup>.
   
   The current logic for sorting the y-axis in the Echarts heatmap includes 
options for sorting by axis or metric in both ascending and descending order. 
However, it appears that the sorting logic may skip y-axis values where the 
metric is null, which could be causing the issue you're experiencing 
<sup>[[2]](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx)</sup>.
   
   There are test cases in the Superset codebase that address sorting behavior 
with null or empty values, which might provide some insight into how these 
cases are handled. For example, the test cases in `series.test.ts` include 
scenarios with null values in the dataset 
<sup>[[3]](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-echarts/test/utils/series.test.ts)</sup>.
   
   If the legacy heatmap sorting works correctly, it might be worth comparing 
the logic between the legacy and current Echarts heatmap implementations to 
identify any differences that could be contributing to this issue 
<sup>[[4]](https://github.com/apache/superset/blob/master/RELEASING/release-notes-4-1/README.md)</sup>.
   
   
   <!-- Dosu Comment Footer -->
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   
   ---
   <sup>Help Dosu learn! Give it feedback: [Great 
Response](https://app.dosu.dev/response-feedback/129749f2-02b4-4fd7-a236-b14d32ee2d70?feedback_type=great_response)
 | [Irrelevant 
Answer](https://app.dosu.dev/response-feedback/129749f2-02b4-4fd7-a236-b14d32ee2d70?feedback_type=irrelevant_answer)
 | [Incorrect 
Sources](https://app.dosu.dev/response-feedback/129749f2-02b4-4fd7-a236-b14d32ee2d70?feedback_type=incorrect_sources)
 | [Too 
Verbose](https://app.dosu.dev/response-feedback/129749f2-02b4-4fd7-a236-b14d32ee2d70?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/129749f2-02b4-4fd7-a236-b14d32ee2d70?feedback_type=hallucination)
 | [Bug 
Report](https://app.dosu.dev/response-feedback/129749f2-02b4-4fd7-a236-b14d32ee2d70?feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/129749f2-02b4-4fd7-a236-b14d32ee2d70?feedback_type=other)</sup>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to