geido opened a new issue, #32543: URL: https://github.com/apache/superset/issues/32543
Please refer to SIP-139 https://github.com/apache/superset/issues/29268. The `Checkbox` component should be upgraded to Ant Design version 5. Similar work has been completed [here](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed). **IMPORTANT:** - The `src/components/Checkbox` is using a customized checkbox that is not leveraging the Ant Design one. This component needs to be refactored to use the Ant Design provided component. - The export from `superset-frontend/src/components/index.ts` as `AntdCheckbox` should be removed and all instances of `Checkbox` should come from `src/components/Checkbox` going forward. - Any other imports of `Checkbox` in the codebase that are directly imported from Ant Design instead of `src/components/Checkbox` should be refactored to use `src/components/Checkbox`. When upgrading the component to Ant Design 5, please ensure to include: - Remove unnecessary custom styles. We want to go as vanilla Ant Design as possible. - Proper RTL test coverage if not present yet. - A Storybook file (if not present) or all necessary changes. - Include all relevant component options in the Storybook. When opening a PR: - Name your PR refactor({Component}): Upgrade {component} to Ant Design 5 - Add screenshots of BEFORE/AFTER in your PR. - Update the [project tracker](https://github.com/apache/superset/discussions/29293) when your PR is merged. - Make sure you or a committer has labeled your PR with [frontend:refactor:antd5](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
