eschutho commented on code in PR #32336:
URL: https://github.com/apache/superset/pull/32336#discussion_r1982288291
##########
superset/reports/api.py:
##########
@@ -574,7 +574,7 @@ def slack_channels(self, **kwargs: Any) -> Response:
"""
try:
params = kwargs.get("rison", {})
- search_string = params.get("search_string")
+ search_string = [params.get("search_string", "").strip()]
Review Comment:
My main concern here is really because we have this utility that converts a
recipient string to a list, and so if we are going to pass around this
search_string as a list, we should probably rename it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
