mistercrunch commented on PR #32520: URL: https://github.com/apache/superset/pull/32520#issuecomment-2702097861
Pointing out something related here, is that the tree component is likely going to be composed of react nodes (not just the description). Today we have [from memory, components names may not match] MetricLabel, ColumnLabel, CalculatedColumnLabel, and these require props beyond what's in folders (description to make a InfoBubbleTooltip, sql_expression, data type, ...). Assuming we want for a rich tree with the full labels (at least on the left panel in explore), this means we'll still have to lookup the related objects from the API. Thinking about future frontend development, we'll need some sort of `assembleTreeDataForComponent(apiPayload)` method, and that it'll have to build rich react nodes. One the other side, we'll need something that takes the `AntdTree.treeData` and prepares the POST payload required by the API, this one should be fairly simple I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
