korbit-ai[bot] commented on code in PR #32510:
URL: https://github.com/apache/superset/pull/32510#discussion_r1980761802
##########
superset/utils/slack.py:
##########
@@ -43,7 +44,12 @@ def get_slack_client() -> WebClient:
token: str = current_app.config["SLACK_API_TOKEN"]
if callable(token):
token = token()
- return WebClient(token=token, proxy=current_app.config["SLACK_PROXY"])
+ client = WebClient(token=token, proxy=current_app.config["SLACK_PROXY"])
+
+ rate_limit_handler = RateLimitErrorRetryHandler(max_retry_count=2)
+ client.retry_handlers.append(rate_limit_handler)
Review Comment:
### Duplicate Rate Limit Handlers <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The rate limit handler is appended without checking if a similar handler
already exists.
###### Why this matters
Multiple calls to get_slack_client() could result in duplicate rate limit
handlers, potentially causing unnecessary retries and delays.
###### Suggested change ∙ *Feature Preview*
Clear existing rate limit handlers before adding a new one:
```python
client.retry_handlers = [h for h in client.retry_handlers if not
isinstance(h, RateLimitErrorRetryHandler)]
client.retry_handlers.append(rate_limit_handler)
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/54d586bf-5ccf-4280-b3a9-c94110eed1e8?suggestedFixEnabled=true)
💬 Chat with Korbit by mentioning @korbit-ai.
</sub>
<!--- korbi internal id:100951dd-a9fe-41d2-b2b3-853185ea6155 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
