betodealmeida opened a new pull request, #32485: URL: https://github.com/apache/superset/pull/32485
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The current flow for user impersonation is confusing. There are two methods that are called, one for modifying the SQLAlchemy URI, and another to modify the `connect_args` argument to `create_engine()`, both called in the `Database` model when building the SQLAlchemy engine. To make things more confusing, the first method (`get_url_for_impersonation`) is called unconditionally, regardless of the status of `impersonate_user`. Instead, it passes `impersonate_user` in an argument to the method, leaving it up to the DB engine spec to decide if the URL should be modified for impersonation. All of our DB engine specs will return the URL unmodified when `impersonate_user` is passed as false. So this PR changes this: ```python sqlalchemy_url = db_engine_spec.get_url_for_impersonation(sqlalchemy_url, impersonate_user, ...) ... if impersonate_user: db_engine_spec.impersonate_user(engine_kwargs, ...). # modifies inplace ``` Into this: ```python if impersonate_user: sqlalchemy_url, engine_kwargs = db_engine_spec.impersonate_user(sqlalchemy_url, engine_kwargs, ...) ``` Since we support 3rd party DB engine specs, the base implementation of `impersonate_user` calls the original methods, to make sure the DB engine specs will remain working even if they don't implement the new method. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
