villebro commented on PR #32473: URL: https://github.com/apache/superset/pull/32473#issuecomment-2692577318
> LGTM. I haven't checked if the feature is covered by RTL, but maybe there's an enhancement if so. If it's enzyme, then I wouldn't bother at this time. I don't think this is testable with RTL, as we're just wrapping ECharts in a thin React component (ECharts implements all the drawing stuff at a very low level with ZRender). But working on this gave me a good proper headache, so this plugin is definitely in need of some cleanup at some point. Once we have the new extensions architecture in place, I'd love for us to give this plugin some TLC and rethink how we can do some real RTL-style testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
