personofnorank commented on PR #30506: URL: https://github.com/apache/superset/pull/30506#issuecomment-2691323795
I'm a bit stumped. It's failing on the tests in `superset-frontend/packages/superset-ui-core/test/time-comparison/getTimeOffset.test.ts` which I added for the "previous calendar quarter" use case as they exist for all the other use cases. I basically cloned the other tests but I'm not sure what exactly they're doing or whether it matters what value of `startDate` you set. Setting different values leads to different values in the error message, which implies I could hack it to get the right value but that doesn't feel right without understanding what it's doing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
