Dev10-34 commented on code in PR #32358:
URL: https://github.com/apache/superset/pull/32358#discussion_r1972065059
##########
superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/controlPanel.tsx:
##########
@@ -224,6 +225,31 @@ const config: ControlPanelConfig = {
['y_axis_format'],
['x_axis_time_format'],
['currency_format'],
+ [<ControlSubSectionHeader>Border</ControlSubSectionHeader>],
+ [
+ {
+ name: 'element_border',
+ config: {
+ type: 'ColorPickerControl',
+ label: t('Border Color'),
+ renderTrigger: true,
+ description: t('Select border color for Heatmap elements'),
+ default: { r: 255, g: 255, b: 255, a: 1 },
+ },
+ },
+ ],
+ [
+ {
+ name: 'enable_border',
Review Comment:
I have implemented my suggestion for the review. Please let me know what
default to keep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
