geido commented on code in PR #32112:
URL: https://github.com/apache/superset/pull/32112#discussion_r1971878875
##########
superset-frontend/src/components/Icons/Icon.tsx:
##########
@@ -48,6 +70,7 @@ export const StyledIcon = styled(AntdIconComponent)<IconType>`
export interface IconProps extends IconType {
fileName: string;
+ customIcons?: boolean;
Review Comment:
Is this prop used for anything in particular?
##########
superset-frontend/src/components/LastUpdated/index.tsx:
##########
@@ -49,14 +49,16 @@ const TextStyles = styled.span`
color: ${({ theme }) => theme.colors.grayscale.base};
`;
-const Refresh = styled(Icons.Refresh)`
- color: ${({ theme }) => theme.colors.primary.base};
+const RefreshIcon = styled(Icons.SyncOutlined)`
+ ${({ theme }) => `
+ color: ${theme.colors.primary.base};
Review Comment:
Should this color be used as a prop of the icon?
##########
superset-frontend/src/pages/CssTemplateList/index.tsx:
##########
@@ -196,7 +198,15 @@ function CssTemplatesList({
subMenuButtons.push({
name: (
<>
- <i className="fa fa-plus" /> {t('CSS template')}
+ <Icons.PlusOutlined
+ iconColor={theme.colors.primary.light5}
+ iconSize="s"
+ css={css`
+ margin: 'auto ${theme.gridUnit * 2}px auto 0';
+ vertical-align: 'baseline';
Review Comment:
I think you don't need to use quoting here. You might want to check others
too
```suggestion
margin: auto ${theme.gridUnit * 2}px auto 0;
vertical-align: baseline;
```
##########
superset-frontend/src/pages/DatasetList/index.tsx:
##########
@@ -624,7 +632,15 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
buttonArr.push({
name: (
<>
- <i className="fa fa-plus" /> {t('Dataset')}{' '}
+ <Icons.PlusOutlined
+ iconColor={theme.colors.primary.light5}
+ iconSize="s"
+ css={css`
+ margin: auto ${theme.gridUnit * 2}px auto 0;
+ verticalalign: baseline;
Review Comment:
```suggestion
vertical-align: baseline;
```
##########
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx:
##########
@@ -110,6 +110,7 @@ const Styles = styled.div`
overflow: hidden;
}
.datasource-svg {
+ color: ${({ theme }) => theme.colors.grayscale.base};
Review Comment:
Can we use this as a prop of the icon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
