betodealmeida commented on code in PR #32231:
URL: https://github.com/apache/superset/pull/32231#discussion_r1968568359
##########
tests/conftest.py:
##########
@@ -106,3 +107,35 @@ def data_loader(
return PandasDataLoader(
example_db_engine, pandas_loader_configuration, table_to_df_convertor
)
+
+
+def with_config(override_config: dict[str, Any]):
Review Comment:
Nice!
##########
superset/commands/database/update.py:
##########
@@ -88,7 +87,14 @@ def run(self) -> Model:
database.set_sqlalchemy_uri(database.sqlalchemy_uri)
ssh_tunnel = self._handle_ssh_tunnel(database)
try:
- self._refresh_catalogs(database, original_database_name,
ssh_tunnel)
+ current_username = get_username()
+ SyncPermissionsCommand(
Review Comment:
So much better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
