rad-pat commented on code in PR #28627:
URL: https://github.com/apache/superset/pull/28627#discussion_r1965097536
##########
superset/db_engine_specs/databend.py:
##########
@@ -273,7 +276,10 @@ def get_parameters_from_uri(
) -> BasicParametersType:
url = make_url_safe(uri)
query = url.query
- if "secure" in query:
Review Comment:
I was hoping the if...elseif... would cope with URLs of both types, so
existing connections using `secure=true/false` would still work anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
