Vitor-Avila opened a new pull request, #32336: URL: https://github.com/apache/superset/pull/32336
### SUMMARY This PR fixes a few things with the Slack method migration from V1 to V2 (required as Slack is fully deprecating `files.upload()` in March): * `get_channels_with_search` was returning a list of dictionaries (one per channel found) and we were dumping this directly in the `target` configuration for a report. The `target` field expects a comma-separated list of channels IDs for the V2 approach. * I've added a schema that drops any additional fields from each channels to reduce information (some organizations could have thousands of channels). * Enforcing `exact_match` search during the migration to avoid for example migrating a report from `other-channel` to `another-channel`. * Stripping channel names before the search to account for `one-channel, second-channel`. Fixes https://github.com/apache/superset/issues/31936 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. ### TESTING INSTRUCTIONS Added testing. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/31936 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
