rusackas commented on PR #32294: URL: https://github.com/apache/superset/pull/32294#issuecomment-2670088552
I have no problem with the timeouts (we might need more of them, honestly!) but I'm wondering if the `jsonrepair` addition might have any unintended side effects. Does that library properly escape the single quote and solve the problem _without_ changing the text? I'm worried there may be any number of strings throughout the codebase with apostrophes, and hope we can handle them properly rather than work around them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
