korbit-ai[bot] commented on code in PR #32313:
URL: https://github.com/apache/superset/pull/32313#discussion_r1962065355
##########
superset-frontend/src/types/TagType.ts:
##########
@@ -28,6 +28,7 @@ export interface TagType {
name: string;
index?: number | undefined;
toolTipTitle?: string;
+ children?: React.ReactNode;
Review Comment:
### Missing React Type Import <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The `children` prop is added without importing `React` type, which will
cause a TypeScript compilation error.
###### Why this matters
Without proper React type import, the application will fail to compile,
preventing the Ant Design 5 upgrade from working correctly.
###### Suggested change ∙ *Feature Preview*
Add React import at the top of the file:
```typescript
import { MouseEventHandler, ReactNode } from 'react';
export interface TagType {
// ... other props
children?: ReactNode;
}
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/4ea0e412-e32e-407b-a080-2b4738dd329d?suggestedFixEnabled=true)
💬 Chat with Korbit by mentioning @korbit-ai.
</sub>
<!--- korbi internal id:f9a591e2-a0b2-4015-a2e5-1c03e8e9f864 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
