korbit-ai[bot] commented on code in PR #32231: URL: https://github.com/apache/superset/pull/32231#discussion_r1952656162
########## superset/config.py: ########## @@ -1916,6 +1916,15 @@ class ExtraDynamicQueryFilters(TypedDict, total=False): CATALOGS_SIMPLIFIED_MIGRATION: bool = False +# When updating a DB connection or manually triggering a resync, the command +# happens in sync mode. If you have a celery worker configured, it's recommended +# to change below config to ``True`` to run this process in async mode. A DB +# connection might have hundreds of catalogs with thousands of schemas each, which +# considerably increases the time to process it. Running it in async mode prevents +# keeping a web API call open for this long. +RESYNC_DB_PERMISSIONS_IN_ASYNC_MODE: bool = False Review Comment: Thank you Vitor for clarifying the requirement for Celery workers in your implementation. However, could you please enhance the feature to check if Celery workers are running and automatically enable or disable the async mode based on the status? This would make the feature more robust, and it would cater to both scenarios (with and without Celery workers) without needing user intervention. Please consider this for your next Iteration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
