geido commented on code in PR #32222:
URL: https://github.com/apache/superset/pull/32222#discussion_r1950972464
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -100,19 +100,23 @@ const Styles = styled.div`
margin: 0 8px;
}
.sdm-input {
- margin-left: 45px;
+ margin-left: 40px;
Review Comment:
Can we use the `gridUnit` here? This whole piece style is not using the
gridUnit for margins and paddings as it should, can you update it, please?
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -100,19 +100,23 @@ const Styles = styled.div`
margin: 0 8px;
Review Comment:
We could use `gridUnit` here too
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -100,19 +100,23 @@ const Styles = styled.div`
margin: 0 8px;
}
.sdm-input {
- margin-left: 45px;
+ margin-left: 40px;
width: 401px;
}
.sdm-autocomplete {
width: 401px;
align-self: center;
+ margin-left: 4px;
Review Comment:
Same let's use `gridUnit`
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -100,19 +100,23 @@ const Styles = styled.div`
margin: 0 8px;
}
.sdm-input {
- margin-left: 45px;
+ margin-left: 40px;
width: 401px;
}
.sdm-autocomplete {
width: 401px;
align-self: center;
+ margin-left: 4px;
}
.sdm-radio {
- display: block;
height: 30px;
margin: 10px 0px;
line-height: 30px;
}
+ .sdm-radio span {
+ display: inline-flex;
+ padding-right: 0px;
+ }
.sdm-overwrite-msg {
margin: 7px;
Review Comment:
Wow, can this be `8px` and use `gridUnit * 2` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
