mistercrunch commented on PR #32191: URL: https://github.com/apache/superset/pull/32191#issuecomment-2649083619
I think @rusackas has this one too https://github.com/apache/superset/pull/32207, so I'm going to close this PR and slowly back off. If anything we learned a few things in this PR 1. there are about 50 enzyme-backed test files around (not only a dozen like I thought originally) 1. other people seem interested to convert the tests to RTL I think overall we think that more test coverage is better, even if the tests aren't fully redesigned for RTL. Anyhow, closing this PR and passing the baton here... I anything I'd advocate to be radical around approaching the migration. If some tests are hard to convert, it's acceptable to delete chunks or the file altogether. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
