kgabryje commented on code in PR #32207:
URL: https://github.com/apache/superset/pull/32207#discussion_r1949450317


##########
superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.test.tsx:
##########
@@ -164,26 +164,43 @@ test('render menu item with submenu without searchbox', 
async () => {
   expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
 });
 
+// Add global timeout for all tests
+jest.setTimeout(20000);

Review Comment:
   Maybe lets increase it globally in jest.config.js? I recently increased the 
timeout to 10000 (from the default 5000), but if we need more then why not 
(though tbh 20s sounds like _a lot_ for a single unit test)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to