msyavuz commented on PR #31972: URL: https://github.com/apache/superset/pull/31972#issuecomment-2643268924
> Not sure if it was like that before, but any chance we could make it stay in 1 line? Or if it needs to wrap, make it stay in the column with text and not go into the column with icons? If it's not a regression, we can fix it in a separate PR That was regression. Fixed it now! > Is the filter bar orientation submenu supposed to be a different color? Yes, that was the same on master as well. > Again, not sure if it's present on master or not, but we shouldn't display a divider here if there's only "Set up report" button available (both in Explore and Dashboard) This was also present in master > Oh interesting... I'm on sha 6b62b6 (fix(test): change the role) > I double checked, I can repro this issue on any dashboard. The actions connected to those buttons work fine though Yeah, that one i am not sure what can cause the behaviour difference as i can't reproduce it. I appreciate the detailed review and testing. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
