DuanKuanJun commented on PR #32041: URL: https://github.com/apache/superset/pull/32041#issuecomment-2636256931
> LGTM. There's still CI issues, please check those. You may benefit from installing pre-commit hooks. Please check https://superset.apache.org/docs/contributing/development#git-hooks, as these automatically correct any code formatting issues for you. root@test ~/dev/superset (master)$ pre-commit run --files ./superset/db_engine_specs/TDengine.py [INFO] Initializing environment for https://github.com/MarcoGorelli/auto-walrus. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy:types-simplejson,types-python-dateutil,types-requests,types-redis==4.6.0.4,types-pytz,types-croniter,types-PyYAML,types-setuptools,types-paramiko,types-Markdown. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier:[email protected]. [INFO] Initializing environment for https://github.com/skorokithakis/blacklist-pre-commit-hook. [INFO] Initializing environment for https://github.com/norwoodj/helm-docs. [INFO] Initializing environment for https://github.com/astral-sh/ruff-pre-commit. [INFO] Installing environment for https://github.com/MarcoGorelli/auto-walrus. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-prettier. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/skorokithakis/blacklist-pre-commit-hook. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/astral-sh/ruff-pre-commit. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... auto-walrus..............................................................Passed mypy.....................................................................Passed check docstring is first.................................................Passed check for added large files..............................................Passed check yaml...........................................(no files to check)Skipped debug statements (python)................................................Passed fix end of files.........................................................Passed trim trailing whitespace.................................................Passed prettier.............................................(no files to check)Skipped eslint...............................................(no files to check)Skipped Blacklist................................................................Passed Helm Docs............................................(no files to check)Skipped ruff.....................................................................Passed ruff-format..............................................................Passed root@test ~/dev/superset (master)$ local machine check passed, submit agagin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
