eschutho commented on code in PR #31333:
URL: https://github.com/apache/superset/pull/31333#discussion_r1938107616
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:
##########
@@ -290,12 +292,20 @@ export default function transformProps(
const showValueIndexesB = extractShowValueIndexes(rawSeriesB, {
stack,
});
+
+ const metricsLabels = metrics
+ .map(metric => getMetricLabel(metric, undefined, undefined, verboseMap))
+ .filter((label): label is string => label !== undefined);
+ const metricsLabelsB = metricsB.map((metric: QueryFormMetric) =>
+ getMetricLabel(metric, undefined, undefined, verboseMap),
Review Comment:
@kgabryje lmk what you think. I don't like having to pass a bunch of
undefined values, but it felt safer here than changing the args to kwargs (a js
object). A bunch of the map functions are passing values that were unused in
getMetricLabel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
