martyngigg commented on PR #30134:
URL: https://github.com/apache/superset/pull/30134#issuecomment-2624698921

   > Hi @martyngigg I believe you might have missed some places in the 
frontend: This is kind of a hedge case, but if you edit a dashboard, go to 
"save as", select overwrite, it is redirecting to 
/superset/dashboard/yourdashslug after you save a dashboard edit (no prefix 
anymore)
   > 
   > I believe it might be due to 
https://github.com/martyngigg/superset/blob/allow_prefixed_paths/superset-frontend/src/dashboard/actions/dashboardState.js#L410
 messing up the browser history also, at some point.
   > 
   > Reproduce it:
   > 
   >     * edit a dashboard
   > 
   >     * save as
   > 
   >     * overwrite
   > 
   >     * you get redirected to the prefix-less path
   
   Thanks! I think I've fixed this now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to