mistercrunch commented on code in PR #31998:
URL: https://github.com/apache/superset/pull/31998#discussion_r1932518457
##########
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/handlebarTemplate.tsx:
##########
@@ -33,13 +34,32 @@ interface HandlebarsCustomControlProps {
const HandlebarsTemplateControl = (
props: CustomControlConfig<HandlebarsCustomControlProps>,
) => {
+ const theme = useTheme();
+
const val = String(
props?.value ? props?.value : props?.default ? props?.default : '',
);
+ const helpersDescription = `
+Available Handlebars Helpers in Superset:
Review Comment:
Would be great to i18n this for consistency, would recommend cutting into
1-sentence chunks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
