mistercrunch commented on code in PR #32006:
URL: https://github.com/apache/superset/pull/32006#discussion_r1931480153
##########
superset-frontend/src/views/App.tsx:
##########
@@ -83,13 +83,9 @@ const App = () => (
{routes.map(({ path, Component, props = {}, Fallback = Loading }) => (
<Route path={path} key={path}>
<Suspense fallback={<Fallback />}>
- <Layout.Content>
- <div style={{ padding: '16px' }}>
- <ErrorBoundary>
- <Component user={bootstrapData.user} {...props} />
- </ErrorBoundary>
- </div>
- </Layout.Content>
+ <ErrorBoundary style={{ margin: '16px' }}>
Review Comment:
wanted to do `theme.sizeUnit * 4` but theme isn't in context here so bailed
and went for hard-coded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
