justinpark opened a new pull request, #32005:
URL: https://github.com/apache/superset/pull/32005

   ### SUMMARY
   Fixes 
https://github.com/apache/superset/pull/31858#pullrequestreview-2567399027
   
   In #31858, unnecessary space was created on all pages due to the div with 
added padding.
   |Before|After|
   |--|--|
   |![Screenshot_2025-01-27_at_6_20_03 
PM](https://github.com/user-attachments/assets/12c2dfec-ac2d-4a4c-8f9a-7cf1c0cea5f2)|![Screenshot_2025-01-27_at_6_19_44
 
PM](https://github.com/user-attachments/assets/a776daf8-60b0-4a27-b741-166ca25bfbf1)
   
   The intention of this padding was to provide [space for the alert 
container](https://github.com/apache/superset/pull/31858#issuecomment-2593398152).
 To resolve this issue, I removed the div and added margin to the alert 
instead. 
   
   ![Screenshot 2025-01-27 at 6 03 47 
PM](https://github.com/user-attachments/assets/b26db8f7-7857-4cbd-ae71-bc61873fc027)
   Additionally, the Layout.Content component caused issues with the full page 
height, resulting in improper rendering of the SQL Lab tab. This was fixed by 
adding `display:flex`.
   
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   |Before|After|
   |--|--|
   |![Screenshot 2025-01-27 at 6 20 26 
PM](https://github.com/user-attachments/assets/cb3c95f5-2eec-4dbf-8df9-1ba36950504c)|![Screenshot
 2025-01-27 at 6 20 10 
PM](https://github.com/user-attachments/assets/d36af505-2346-4ab8-b6d4-1dc65d3b09c5)|
   |![Screenshot 2025-01-27 at 6 19 44 
PM](https://github.com/user-attachments/assets/b2bde732-ca73-46a7-8e33-080ad35d08e9)|![Screenshot
 2025-01-27 at 6 20 03 
PM](https://github.com/user-attachments/assets/bfc1addc-2c55-4292-ab89-08960b457954)|
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to