dosubot[bot] commented on issue #31983:
URL: https://github.com/apache/superset/issues/31983#issuecomment-2612794825

   <!-- Greeting -->
   Hey, @buschtoens! I'm here to help you with this issue. I can assist you 
with bugs, answer questions, and guide you to become a contributor. Let's 
tackle this together!
   
   <!-- Answer -->
   I found a similar unsolved discussion regarding the exposure of username and 
password when importing data sources using the `import_datasource` command. You 
can view the discussion 
[here](https://github.com/apache/superset/discussions/30984) 
<sup>[[1]](https://github.com/apache/superset/discussions/30984)</sup>.
   
   Regarding your issue, the `superset import_datasources` command currently 
does not encrypt the database password in the `sqlalchemy_uri`. The password 
remains in clear text, which is not the expected behavior if you want it to be 
redacted as it is when editing via the web UI. The current implementation does 
not include logic for handling or encrypting passwords in the `sqlalchemy_uri` 
during the import process 
<sup>[[2]](https://github.com/apache/superset/blob/master/superset/db_engine_specs/README.md)</sup>.
   
   The Superset web UI handles password encryption by masking the password in 
the API response, and similar logic could potentially be applied to the import 
process. However, this would require changes to the current implementation to 
ensure that passwords are encrypted or masked during import 
<sup>[[2]](https://github.com/apache/superset/blob/master/superset/db_engine_specs/README.md)</sup>.
   
   
   <!-- Dosu Comment Footer -->
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   
   ---
   <sup>Help Dosu learn! Give it feedback: [Great 
Response](https://app.dosu.dev/response-feedback/14cafe67-cd19-4313-9ba7-6c575db6bb0a?feedback_type=great_response)
 | [Irrelevant 
Answer](https://app.dosu.dev/response-feedback/14cafe67-cd19-4313-9ba7-6c575db6bb0a?feedback_type=irrelevant_answer)
 | [Incorrect 
Sources](https://app.dosu.dev/response-feedback/14cafe67-cd19-4313-9ba7-6c575db6bb0a?feedback_type=incorrect_sources)
 | [Too 
Verbose](https://app.dosu.dev/response-feedback/14cafe67-cd19-4313-9ba7-6c575db6bb0a?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/14cafe67-cd19-4313-9ba7-6c575db6bb0a?feedback_type=hallucination)
 | 
[Other](https://app.dosu.dev/response-feedback/14cafe67-cd19-4313-9ba7-6c575db6bb0a?feedback_type=other)</sup>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to