mistercrunch commented on code in PR #31860:
URL: https://github.com/apache/superset/pull/31860#discussion_r1917162524
##########
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx:
##########
@@ -113,7 +113,7 @@ const SqlEditorLeftBar = ({
'schema',
]);
- const [emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);
+ const [_emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);
Review Comment:
I think we need `setEmptyResultsWithSearch`, and are flushing position 1 of
the array. Code is a bit cryptic to me here. Not sure why we need
`setEmptyResultsWithSearch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
