geido commented on code in PR #31798:
URL: https://github.com/apache/superset/pull/31798#discussion_r1913047148
##########
superset/dashboards/api.py:
##########
@@ -1141,6 +1130,7 @@ def thumbnail(self, pk: int, digest: str, **kwargs: Any)
-> WerkzeugResponse:
)
@expose("/<pk>/cache_dashboard_screenshot/", methods=("POST",))
+ @validate_feature_flags(["THUMBNAILS",
"ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS"])
Review Comment:
I am thinking if we really need the couple here at this point or
`ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS` will suffice. What's your thought? I
have been meaning to remove this dependency before and this could be a good
chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
