kgabryje commented on code in PR #31754:
URL: https://github.com/apache/superset/pull/31754#discussion_r1908754712
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx:
##########
@@ -98,49 +83,20 @@ const FilterScope: FC<FilterScopeProps> = ({
useEffect(() => {
const updatedFormValues = {
scope: initialFilterScope,
- scoping: initialScopingType,
};
updateScopes(updatedFormValues);
- }, [initialFilterScope, initialScopingType, updateScopes]);
+ }, [initialFilterScope, updateScopes]);
return (
<Wrapper>
- <CleanFormItem
- name={[...pathToFormValue, 'scoping']}
- initialValue={initialScopingType}
- >
- <Radio.Group
- onChange={({ target: { value } }) => {
- const scope =
- value === ScopingType.All
- ? getDefaultScopeValue(chartId)
- : lastSpecificScope.current;
- updateFormValues({ scope });
- setHasScopeBeenModified(true);
- forceUpdate();
- }}
- >
- <Radio value={ScopingType.All}>{t('Apply to all panels')}</Radio>
- <Radio value={ScopingType.Specific}>
- {t('Apply to specific panels')}
- </Radio>
- </Radio.Group>
- </CleanFormItem>
- <Typography.Text type="secondary">
- {(formScopingType ?? initialScopingType) === ScopingType.Specific
- ? t('Only selected panels will be affected by this filter')
Review Comment:
Should we keep this text somewhere? In some sort of tooltip maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
