korbit-ai[bot] commented on code in PR #31718: URL: https://github.com/apache/superset/pull/31718#discussion_r1903914945
########## superset-frontend/src/components/Steps/Steps.stories.tsx: ########## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Steps, StepsProps } from '.'; + +export default { + title: 'Steps', + component: Steps, +}; + +export const InteractiveSteps = (args: StepsProps) => <Steps {...args} />; +InteractiveSteps.args = { + direction: 'horizontal', + initial: 0, + labelPlacement: 'horizontal', + progressDot: false, + size: 'default', + status: 'process', + type: 'default', + items: [], Review Comment: ### Missing Demo Steps in Story <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? The 'items' array is empty in the default props, making the Steps component render without any steps, which doesn't demonstrate its functionality in the Storybook story. ###### Why this matters Without sample items, users of the Storybook documentation won't be able to see how the Steps component actually looks and behaves with real data. ###### Suggested change Add sample items to demonstrate the Steps component: items: [ { title: 'Step 1', description: 'This is step 1' }, { title: 'Step 2', description: 'This is step 2' }, { title: 'Step 3', description: 'This is step 3' }, ], </details> ###### Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews. <!--- korbi internal id:204b73ed-8731-4971-b603-1f727c59e014 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
