coneybeare commented on issue #31686:
URL: https://github.com/apache/superset/issues/31686#issuecomment-2571761698

   Found the reason for this is that the 4.1.1 image (generated 2 months ago) 
does not include the header line in the base template, despite it being in the 
main branch 5 months ago.
   
   ```bash
   $ docker pull apache/superset:4.1.1
   4.1.1: Pulling from apache/superset
   Digest: 
sha256:1d1fdaaeb19ce9cdba71620ee1cc6117d73813b2f3b422ce5a1bf752c247b7c0
   Status: Downloaded newer image for apache/superset:4.1.1
   docker.io/apache/superset:4.1.1
   
   $ docker run -it apache/superset:4.1.1 /bin/bash
   superset@9dc92dd9e405:/app$ cat superset/templates/superset/base.html
   {#
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   #}
   {% extends "appbuilder/baselayout.html" %}
   {% from 'superset/partials/asset_bundle.html' import css_bundle, js_bundle 
with context %}
   
   {% block head_css %}
     {{ super() }}
     {% set favicons = appbuilder.app.config['FAVICONS'] %}
     {% for favicon in favicons %}
       <link
         rel="{{favicon.rel if favicon.rel else "icon"}}"
         type="{{favicon.type if favicon.type else "image/png"}}"
         {% if favicon.sizes %}sizes={{favicon.sizes}}{% endif %}
         href="{{ "" if favicon.href.startswith("http") else assets_prefix 
}}{{favicon.href}}"
       >
     {% endfor %}
     {{ css_bundle("theme") }}
   {% endblock %}
   
   {% block head_js %}
     {{ super() }}
     {{ js_bundle("theme") }}
   {% endblock %}
   
   {% block tail_js %}
     {{ super() }}
     {{ js_bundle("preamble") }}
     {{ js_bundle('menu') }}
     {% include "tail_js_custom_extra.html" %}
   {% endblock %}
   superset@9dc92dd9e405:/app$
   ```
   
   
https://github.com/apache/superset/blob/e311bc1ca5f4bea9407012bd1fd278aa06a988f6/superset/templates/superset/base.html#L38
   
https://github.com/apache/superset/blame/e311bc1ca5f4bea9407012bd1fd278aa06a988f6/superset/templates/superset/base.html#L38


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to