rusackas commented on code in PR #31512: URL: https://github.com/apache/superset/pull/31512#discussion_r1902237552
########## superset-frontend/src/assets/stylesheets/less/variables.less: ########## @@ -184,7 +184,7 @@ } // ****************************** Families ****************************** -@font-family-sans-serif: 'Inter', Helvetica, Arial; +@font-family-sans-serif: 'Inter', Helvetica, Arial, 'Vazirmatn'; Review Comment: The PR doesn't describe the motivation for the fonts in general, but it's probably worth noting that Inter, Helvetica, and Arial will override Vzairmatn in this case, and we're still loading the Inter bundles, so this might just be making the payload/bundle larger for no good reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
