korbit-ai[bot] commented on code in PR #31693: URL: https://github.com/apache/superset/pull/31693#discussion_r1901561353
########## superset-frontend/src/components/Space/Space.stories.tsx: ########## @@ -0,0 +1,60 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Re-exporting of components in src/components to facilitate + * their imports by other components. + * E.g. import { Select } from 'src/components' + */ + +import { Space, SpaceProps } from 'src/components/Space'; + +export default { + title: 'Space', + component: Space, +}; + +export const InteractiveSpace = (args: SpaceProps) => ( + <Space {...args}> + {new Array(20).fill(null).map((_, i) => ( + <p key={i}>Item</p> + ))} + </Space> +); + +InteractiveSpace.args = { + direction: 'horizontal', + size: 'small', + wrap: 'false', Review Comment: ### Incorrect Boolean Value Type <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? The wrap property is set as a string 'false' instead of a boolean false in InteractiveSpace.args. ###### Why this matters This will cause the wrap property to be treated as a truthy string value rather than a boolean false, leading to unexpected wrapping behavior in the Space component. ###### Suggested change Change wrap: 'false' to wrap: false </details> ###### Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews. <!--- korbi internal id:b1ad73e4-e8f8-46bc-bb68-e06d8e36385f --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
