villebro commented on code in PR #31688:
URL: https://github.com/apache/superset/pull/31688#discussion_r1901238231
##########
helm/superset/README.md:
##########
@@ -66,7 +66,7 @@ On helm this can be set on
`extraSecretEnv.SUPERSET_SECRET_KEY` or `configOverri
| envFromSecret | string | `"{{ template \"superset.fullname\" . }}-env"` |
The name of the secret which we will use to populate env vars in deployed pods
This can be useful for secret keys, etc. |
| envFromSecrets | list | `[]` | This can be a list of templated strings |
| extraConfigMountPath | string | `"/app/configs"` | |
-| extraConfigs | object | `{}` | Extra files to mount on `/app/pythonpath` |
+| extraConfigs | object | `{}` | Extra files to mount on `/app/configs` |
Review Comment:
While we're at it, maybe we can update the description for both
`extraConfigs` and `extraSecrets` to explain that the mount points aren't
static, but will in fact be mounted on the path defined in
`extraConfigMountPath` and `configMountPath`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
